Medieval Wall

[Korean Gamer]

Oh my god so cutie

 

[Uyarrr]

Solid and Useful

 

[The_Silent]

Might have to do a ramp.
In case people want to use them as cliffs or something.
(And a no-connections piece. I'm not totally happy with the 4-way connection as base piece)

 

[Henry_AC]

This model will be very useful for future zombie maps and others in which you will have to endure masses of enemies.

 

[Paillan]

Where have I seen this before... OH RIGHT!

Fortification wall

I made this for a wall system a while ago. I wanted to have buildable and walkable walls (via triggers) with different animations for each level of destruction: -Undamaged (Stand) -Damaged with destroyed battlement (Stand upgade first) -Destroyed with only the destructed base remaining...

www.hiveworkshop.com

I am not trying to pull you down or anything, but I think we have way too many medieval walls already

 

[The_Silent]

...

People wanted a medieval variant of my concrete barrier. This is pretty much it

 

[Archian]

Very useful. Maybe add a gate as well?

 

[FlameofChange]

That's very nice !
Is it possible to have 6x4 and 4x6 variants ?
Keep the good job, we need more people like you these days.

 

[The_Silent]

That's very nice !
Is it possible to have 6x4 and 4x6 variants ?
Keep the good job, we need more people like you these days.

6x4 and 4x6?

 

[FlameofChange]

6x4 and 4x6?

I mean, yours is 4x4 tiles (like a farm), and in my map there's 6x4 and 4x6 walls (for horizontal and vertical).
But that can be edited through triggering, so it's not a big deal.

 

[Kuzakani]

I cant open the test map, is it suppost to not be allowed?

 

[Hazop / Sarven]

Mans just keeps making better and better stuff, holy shiii this is insanely useful

 

[Kuzakani]

I mean, yours is 4x4 tiles (like a farm), and in my map there's 6x4 and 4x6 walls (for horizontal and vertical).
But that can be edited through triggering, so it's not a big deal.

why dont you just make your wall models nxn size?

 

[ILH]

A good custom set of medieval walls with various configurations.
Works in-game. Approved!

 

[The_Silent]

I cant open the test map, is it suppost to not be allowed?

Might be a version issue. It uses functions that works exclusively for post-reforged versions of wc3. To be precise the unit change skin functions.

 

[Kuzakani]

Might be a version issue. It uses functions that works exclusively for post-reforged versions of wc3. To be precise the unit change skin functions.

yeah you right, i found the problem is the native function that change the skin, thanks.

 

[LocoM]

yeah you right, i found the problem is the native function that change the skin, thanks.

what would be the version? tell me please

 

[Kuzakani]

what would be the version? tell me please

whatever version that has BlzSetUnitSkin native function, i would say 1.31+ however i cant find any changelog mentioning the function. i can mod this to work with previus versions if the OP allow me to.

 

[The_Silent]

You can just replace the unit. Would have used replace, if changing skin wasn't just better in most ways (Doesn't break selection, doesn't break continuous effect, only require you maintain one unit in the object editor, etc.).

... i can mod this to work with previus versions if the OP allow me to.

Feel free to.

 

[Kuzakani]

You can just replace the unit. Would have used replace, if changing skin wasn't just better in most ways (Doesn't break selection, doesn't break continuous effect, only require you maintain one unit in the object editor, etc.).




Feel free to.

Yeah, but there's another way that doesnt break the buffs, effects nor selection. I already made the one with the native func to replace, however im going to try another way.

what would be the version? tell me please

 

[LocoM]

Simplemente puede reemplazar la unidad. Habría usado reemplazar, si el cambio de aspecto no fuera mejor en la mayoría de las formas (no interrumpe la selección, no interrumpe el efecto continuo, solo requiere que mantenga una unidad en el editor de objetos, etc.).




No dude en.

How would the system be in that aspect since some would use it for campaigns in previous versions

 

[Kuzakani]

How would the system be in that aspect since some would use it for campaigns in previous versions

it wouldn't work well with effects, also it would feel uncomfortable for people very special with some little bugs, for example you has the orc catapult with the fire effects, if the wall is attacked while being constructed, at the end of construction the effect will be removed. Where it could be more noticeable is for example you give the wall a carrying ability like the orcs burrows, when the code works your units inside the building will get lost. Also the wall could move to the next position in rare cases.

No trabajara bien con efectos, ademas se sentiría incomodo para gente que es muy especial con los pequeños bugs, por ejemplo la catapulta orca con su efecto de fuego, si el muro es atacado miestras está siendo construido, al final de la construcción el efecto será removido. Donde se notaría más sería por ejemplo si le das al muro una habilidad de cargar unidades como las madrigueras orcas, cuando el codigo corra, las unidades que están guarnecidas se perderán. Además el muro se movera a la posición de al lado en casos raros.

Lucky ive already made the code which doesnt need the "replace" native function. However i wont post it yet, id added a variant wall to the code also made my own wall models, ill post it as contribution only if the OP allows to do so, anyway i want to add some other buildings models to post it as a set.

Por suerte ya hice el codigo el cuál no necesita la función nativa "replace". Sin embargo no lo posteare aún, he agregado una nueva variante de muro al codigo e hice my propio modelo de muros, lo posteare como una contribución solo si el OP me lo permite, de cualquier forma quiero agregar algunos otros modelos de edificios para postearlo como un set.

This one works fine, doesnt use skin function nor replace function, i could share it with you. The problem is that i cant save it as a previus map versión, so i could share the code with you (if OP allows me to) also the model i completly modified to work this way and give you instructions.

 

[The_Silent]

Sure, go ahead.

 

[Chimako]

It's Awesome, You are amazing. Is there a way to create a 3D ramp in the same style?

 

[HandsOfficial]

awesome
reminds me of stronghold warlords

 

[NigerianPriest]

Any gates that go nice with this model?

 

[Rojany]

it wouldn't work well with effects, also it would feel uncomfortable for people very special with some little bugs, for example you has the orc catapult with the fire effects, if the wall is attacked while being constructed, at the end of construction the effect will be removed. Where it could be more noticeable is for example you give the wall a carrying ability like the orcs burrows, when the code works your units inside the building will get lost. Also the wall could move to the next position in rare cases.


Lucky ive already made the code which doesnt need the "replace" native function. However i wont post it yet, id added a variant wall to the code also made my own wall models, ill post it as contribution only if the OP allows to do so, anyway i want to add some other buildings models to post it as a set.


This one works fine, doesnt use skin function nor replace function, i could share it with you. The problem is that i cant save it as a previus map versión, so i could share the code with you (if OP allows me to) also the model i completly modified to work this way and give you instructions.

Hey, could you share with us that code which doesn't need the "replace" native function ? I play on 1.27b and I would love to use this wall system, it's much easier to use in-game than the one I created for my maps, which relies on individual buildings with different orientations.

 

[Barade]

Really useful! The system is great. I was thinking about using elevator like walls, so units can move on top of the walls and not be attacked by melee units. Whenever a wall piece changes: is destroyed or a new one is added, the elevator walls must be updated or the elevators must be removed/added, so units can move further on the walls and no units can move up. It would require some wall pieces open in one direction where units could move on the wall or maybe some entries with portals.

Code Review:
I might found some leaks and performance issues in the code:

set bj_wantDestroyGroup = true // no leaks
call GroupAddGroup(GetUnitsInRangeOfLocAll(sub_dist, loc), udg_temp_group)

...

set loc = Location(pos_x, pos_y)
...
call RemoveLocation(loc) // no leak

The dir parameter of WallDetectNeighbours could be an integer but I guess one small string is not important.

// Early exits
    if IsUnitAliveBJ(GetTriggerUnit()) == false then
         set n = null
        set s = null
        set e = null
        set w = null
       
        return
    endif

shouldn't this be u the passed parameter instead of GetTriggerUnit()?
This would improve the performance:

 set count = CountUnitsInGroup(udg_temp_group)

    // End piece
    if count == 1 then

For me a vJass version of the system would be welcomed as well but the current version is fine, too. If you know any good pathing/shortest path algorithms you might be able to achieve something where two pieces will be automatically connected by with wall pieces in between but that might be too complicated. You could release the system separately in the spells section for a better review. I think it is really useful for anyone who needs walls in Warcraft.

I would also appreciate some matching gates as someone wrote before me. You could allow gates by upgrading a wall piece or selling a unit.

NigerianPriest​

NigerianPriest​

me

 

[Tristronic]

I downloaded this to use in a custom map and am very happy.

I like the detail on the texture - I'm using the wall as a walkable cliff and at 5.25x size it still looks great!

My one two-part complaint is that the lighting/shadows don't look the best, but I know warcraft doesn't have the best lighting out there. It also might be my fault because I only downloaded 5 parts of the set and rotate them instead of using all the differently angle models.
That's the other part of my complaint, why 4 angles of each wall? Maybe that would have solved my lighting issue to use the different angles ?

Still, don't let that detract, these models are great!

 

[The_Silent]

The separate models is for people who want to use them as buildible structures, I assume it is still a pain in the a, to rotate structures in wc3.

The shadows is a bit borked some places indeed. Milkshape had a bug back then that turned shading from per-polygon to per-face shading (flat-shading), which meant I had to recalculate normals in Reteras Model Studio for each side. The pipeline for making 3D models in wc3 was always... Interesting.