Does "GetUnitLoc" and "GetSpellTargetLoc" leak?

[Geshishouhu]

Do they leak? If not, are they efficient?

 

[chobibo]

They won't if you remove it if it's no longer needed; Reals are better, unless you're manipulating the z axis.

 

[TriggerHappy]

Any location will leak if it's not removed, so use coordinates as chobibo said.

Also, when using a local location variable (local location l = GetUnitLoc()), it has to be nulled before the function ends.

 

[Geshishouhu]

They won't if you remove it if it's no longer needed; Reals are better, unless you're manipulating the z axis.

Thanks, buddy.

Any location will leak if it's not removed, so use coordinated as chobibo said.

Also, when using a local location variable (local location l = GetUnitLoc()), it has to be nulled before the function ends.

Got it, thanks.

 

[chobibo]

Dude try looking on the common.j (extract it from the mpq), look for all types related to agents, IIRC, all those leak references when not nulled.

 

[Geshishouhu]

Dude try looking on the common.j (extract it from the mpq), look for all types related to agents, IIRC, all those leak references when not nulled.

Will do.

 

[Spartipilo]

does
DestroyLocation(LocationVariable) works the same as nullying the variable that holds the Location handle?

I think you have to destroy the location, and then null the variable.

 

[TriggerHappy]

>> DestroyLocation(LocationVariable) works the same as nullying the variable that holds the Location handle?

No, both are required to be leakless.

Also, you don't need to null globals.

 

[FUJI]

Use coordinates because they're much faster than locations, coordinates does not need to remove because they're real.
GetUnitLoc:
Using Locations: Does need to remove.

local location MyLoc = GetUnitLoc ( MyUnit )
call RemoveLocation ( MyLoc )
set MyLoc = null

Using Coordinates: Does not need to remove.

local real x = GetUnitX ( MyUnit )
local real y = GetUnitY ( MyUnit )

GetSpellTargetLoc:
Using Locations: Does need to remove.

local location MyLoc = GetSpellTargetLoc ( )
call RemoveLocation ( MyLoc )
set MyLoc = null

Using Coordinates: Does not need to remove.

local real x = GetSpellTargetX ( )
local real y = GetSpellTargetY ( )

 

[Geshishouhu]

Use coordinates because they're much faster than locations, coordinates does not need to remove because they're real.
GetUnitLoc:
Using Locations: Does need to remove.

local location MyLoc = GetUnitLoc ( MyUnit )
call RemoveLocation ( MyLoc )
set MyLoc = null

Using Coordinates: Does not need to remove.

local real x = GetUnitX ( MyUnit )
local real y = GetUnitY ( MyUnit )

GetSpellTargetLoc:
Using Locations: Does need to remove.

local location MyLoc = GetSpellTargetLoc ( )
call RemoveLocation ( MyLoc )
set MyLoc = null

Using Coordinates: Does not need to remove.

local real x = GetSpellTargetX ( )
local real y = GetSpellTargetY ( )

Thanks, +Rep

 

[Maker]

Also, you don't need to null globals.

I ran a test, global location nulled -> no memory increase in task manager. Not nulled -> consntant increase of memory consumption.

I created/destroyed at least 100 000 locations.

 

[chobibo]

Those must be reference leaks.

 

[Geshishouhu]

I ran a test, global location nulled -> no memory increase in task manager. Not nulled -> consntant increase of memory consumption.

I created/destroyed at least 100 000 locations.

Are you sure the increase of memory consumption is because of nulling the global locations? I never null such globals and any kind of global... -_-

Edit:
how did you null them? Just like nulling local locations?

 

[chobibo]

It's true, try it yourself when in doubt.

 

[Geshishouhu]

Those must be reference leaks.

It's true, try it yourself when in doubt.

I will do that when I can, using a Mac right now.