[Solved] What is the difference?

[reeqiz]

What's the difference between these and which one should I use?

Option A

• Set ScalperPickedGroup = (Units within 120.00 of ScalperDummyLoc matching (((((Matching unit) is A structure) Equal to False) and (((Matching unit) is Magic Immune) Equal to False)) and ((((Matching unit) is Mechanical) Equal to False) and ((((Matching unit) is alive) Equal to True)
• Set ScalperDamageGroup = (Random 1 units from ScalperPickedGroup)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Number of units in ScalperDamageGroup) Greater than or equal to 1
  • Then - Actions

Or

Option B

• Set ScalperPickedGroup = (Units within 120.00 of ScalperDummyLoc matching (((((Matching unit) is A structure) Equal to False) and (((Matching unit) is Magic Immune) Equal to False)) and ((((Matching unit) is Mechanical) Equal to False) and ((((Matching unit) is alive) Equal to True)
• Unit Group - Pick every unit in ScalperPickedGroup and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in ScalperPickedGroup) Greater than or equal to 1
      • Then - Actions
        • Set ScalperPickedTarget = (Random unit from ScalperPickedGroup)
      • Else - Actions

 

[rulerofiron99]

Neither.

Use:

• Actions
  • Set ScalperPickedGroup = (Units within 120.00 of Scalp etc
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Number of units in ScalperPickedGroup) Greater than or equal to 1
    • Then - Actions
      • Set ScalperPickedTarget = (Random unit from ScalperPickedGroup)
    • Else - Actions
  • Custom script: call DestroyGroup(udg_ScalperPickedGroup)

 

[reeqiz]

Thank you sir, though is there a downside to ''Picking all units'' in a certain group, suggesting the group ends up being cleared and destroyed?

 

[rulerofiron99]

Although you're picking all units in a group, you aren't actually doing anything to them.

 

[reeqiz]

Ok, well topic solved, thank you!

 

[Cokemonkey11]

I can one-up you and name an even better method - since your group doesn't need to persist its contents, you can use a global group, thus avoiding creating and destroying them each time the trigger runs (a huge optimization)

scope example initializer i
    globals
        private group grp=CreateGroup()
    endglobals
    
    private function i takes nothing returns nothing
        call GroupEnumUnitsInRange(...)
        //now get a random unit and do your stuff with it
        //voila, you never have to dynamically create and remove groups
    endfunction
endscope