How to use sounds?

[Fingolfin]

How do you really play sounds in warcraft?
It always seem to bug for me, if i do it it GUI with "play sound" then "destroy sound", the sound only plays the first time the trigger is fired, if even then.

I then tried to make a jass function to handle it, it looked like this:

function PlaySoundLocal takes player p, string path returns nothing
local sound snd = CreateSound(path, false, false, false, 10, 10, null)
call StartSoundForPlayerBJ(p, snd)
call KillSoundWhenDone(snd)
set snd = null
endfunction

And fired with:

call PlaySoundLocal(GetOwningPlayer(GetBuyingUnit()), "Sound\\Interface\\ClanInvitation.wav")

But again, it doesn't play.
So how do you play sounds correctly?

EDIT: The error was in the rest of my trigger, the sound now plays well in the jass function.
Though i would like to know, does it leak?
Since i create the sound for all players, plays it for one, then deletes it once it's done playing for that player?

 

[Pharaoh_]

• Trigger1
• Events
  • Unit - A unit sells an item (from shop)
• Conditions
• Actions
  • Custom script: if GetLocalPlayer() == GetOwningPlayer(GetBuyingUnit()) then
  • Sound - Play <Sound <gen>>
  • Custom script: endif

That simple.
Notice that some sounds might either require removal of the "3d sound" flag in the Sound Editor or the opposite; test it.

 

[Silvenon]

Though i would like to know, does it leak?

No, because you killed it. But be careful when you play sounds in GUI, you shouldn't destroy them because they are global sounds which are reused each time you play the sound.

 

[Fingolfin]

Does that mean you shouldn't destroy sounds in gui?
It sounds very logical actually, but still not since the sound handle is the only one that has a GUI destroy function.
BTW, i know decent jass, and have worked with flash AS before that, so there's no need for GUI explanation.

 

[Silvenon]

Well, I used to destroy sounds in GUI too, but then when I started learning JASS I noticed that there's only one global sound which can be started and stopped...weird. I don't know what is that destroy action in GUI for. Don't take my word

 

[Pharaoh_]

Apparently Destroy Sound fixes the leak of the sound. To be honest, i recently found out sounds do leak (in the thread "Things that leak"). Why this action could be useful? Instead of doing this: "Custom script: call StopSound(bj_nightAmbientSound, true, true)" (which disables the night sound, the "wolf" one, when time gets 18.00), you could instead go to the Sound Editor, select the sound and use "Sound - Destroy DuskWolf <gen>", for full GUI language

 

[Silvenon]

That's interesting. Luckily, I don't use GUI anymore